Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the API contract smoke tests to detect whether “Extended API” endpoints are actually available on the configured OPENCODE_URL target, and to skip the extended endpoint assertions when the target server responds with the backend’s HTML/SPA fallback instead of JSON (addressing #396).
Changes:
- Add an
Extended APIbeforeAllprobe to/api/ext/saved-promptsand treat the extended API as available only when it returnsapplication/json. - Gate all extended API tests behind
skipIfNoExtendedApi()to avoid JSON parse failures / incorrect assertions when hitting the backend directly. - Print a one-time warning explaining why extended tests are being skipped when unavailable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beforeAllcheck in the "Extended API" describe block that probes/api/ext/saved-promptsfor JSON responseCloses #396